zix http1 entry - #998
Open
prothegee wants to merge 65 commits into
Open
Conversation
Contributor
Author
|
Testing new approach and database tests entries for H1. |
Contributor
Author
|
/benchmark -f zix |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
Oh my, didn't expect the cpu burn that much with high memory consumption. |
prothegee
marked this pull request as draft
July 15, 2026 20:09
prothegee
marked this pull request as ready for review
July 21, 2026 02:43
Contributor
Benchmark ResultsFramework:
Full log |
This branch saved results before MDA2AV#1034, so it carries 20 site/data/<profile>-<conns>.json files that main has since replaced with one file per framework; git reported them all as modify/delete conflicts. Every row this PR added or changed against its merge base was re-applied to site/data/results/zix.json and the flat files dropped - 8 profiles this entry did not publish before (api-4, api-16, async-db, crud, json-comp at three connection counts, json-tls) and 12 it updated (baseline, limited-conn, pipelined, json, static, upload). Two keys already in main were left alone, because this PR did not touch them.
Contributor
Author
|
/benchmark -f zix --save |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
Ready to review before merge, @MDA2AV |
Owner
Beem kinda busy, I'll do a full review tommorow, need some time to do it properly |
Contributor
Author
Sure. Hope you doin well. Regards. |
Owner
|
Ok, I reviewed again. Some things improved but some issues remain. On the upload test, I must say your AI agent really went all in on this test.. technically following the rules but doing something no server would ever do. You count the bytes received but discard them and never read into zix's memory.. it is expected that a server reads the request data to its memory. As this is an engine and test is not scored, we can allow this but keep in mind this would never work on a production server. On json tests, you need to serialize per request, not caching the serialized data at startup and then serve it. This one is important as json-tls is a scored test. There are a lot other things zix is doing that are clearly benchmark oriented and would be a very big problem in a production use, however this is engine section so I won't pick on that but if you are planning on using it as an engine for a real server, there are quite a lot of issues. On CRUD, the ttl seems to be addressed. Regardless, it is an interesting project to push benchmark numbers! :) |
Contributor
Author
|
Yes, zix.Http1 intent really rely on user implementation and promote for user control. I knew it's engine category, but engine correctness is considerable aspect (despite some zix engine/s features). Converting to draft. Thank you. |
prothegee
marked this pull request as draft
July 31, 2026 15:51
prothegee
marked this pull request as ready for review
August 14, 2026 16:48
… propagation - Migrate JSON parsing and serialization across `json`, `crud`, and `dataset` modules to use `jzon`, eliminating manual string building and `std.json` overhead. - Remove response memoization and startup pre-serialization. The `json` handler now serializes per request, and `crudcache` strictly operates as a row-level cache-aside (holding decoded DB rows, not rendered HTTP responses) to accurately reflect benchmark profile constraints. - Replace the custom `static` handler with the engine's native `public_dir` configuration. - Enforce strict error propagation by converting handlers and shared responders (`response.zig`) to return `!void`, replacing silent error swallowing with `try`. - Centralize byte-buffer formatting utilities (integers, strings, JSON escaping) into `shared/util.zig`. - Refactor `dbpg` to use a shared `CrudWrite` payload for create/update jobs and improve lane arming logic for `.URING` vs `.EPOLL`/`.ASYNC` models. - Add comprehensive module-level documentation explaining design choices, benchmark constraints, and engine interactions. - Update `Dockerfile` to target Zix `0.5.x` and change Zig build summary to `failures`. - Add `static-tls` to the `meta.json` test matrix.
Contributor
Author
|
Bump zix branch to 0.5.x and follow-up #1121 (comment) |
Contributor
Author
|
/benchmark -f zix |
Contributor
|
👋 Benchmark request received. A collaborator will review and approve the run. |
Contributor
Benchmark ResultsFramework:
Full log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
zix entry for http1 using 0.5.x branch.
Update:
Checklist:
/benchmark -f zix/benchmark -f zix --save